Codecov Report

Merging #1166 (046b2a6) into main (66e1df3) will increase coverage by 2.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1166      +/-   ##
==========================================
+ Coverage   79.98%   82.14%   +2.15%     
==========================================
  Files         196      196              
  Lines        3383     3383              
  Branches      381      381              
==========================================
+ Hits         2706     2779      +73     
+ Misses        576      512      -64     
+ Partials      101       92       -9     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e1df3...046b2a6. Read the comment docs.

Just for the context, isort check fails now because #1117 got merged, it had all green checks as they were run before isort check was fixed in #1146.

As for the Black, your run on all directory resulting in some changes is, I bet, due to the fact that you are using some recent version of Black and not the one in .pre-commit-config.yaml. In pre-commit it is Black 20.8b1 as well as in CI. As we can see in this case these changes are backwards compatible, cause CI using an older version has passed. But ultimately you should just use pre-commit (pre-commit run -a).

As I've mentioned in #970, switching to pre-commit.ci seems like the best idea.

But as you've run some newer Black on the codebase in this PR, might as well update the version in pre-commit config. And then we could just run this exact version in CI using pre-commit instead of being tied to the 3rd party's Black check version (jpetrucciani/black-check, wasn't updated since September). This is how you add CI check using pre-commit manually (example), until this repo maybe decides to switch to pre-commit.ci.

Might update isort version too.

Thanks! I'll take a look at it once I get back to my machine (would take a couple days).